patches: Use robust patches function to fix corstone300's hardfault #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new way of applying patches is added to fix Corstone300 platform hardfault exception happening as the TF-M patch (components/security/trusted_firmware-m/integration/patches /0001-corstone300-Modify-ISRAM0-to-be-non-secure-partition.patch) for this platform is sometimes not applied. Patches are now applied using `git stash` and `git apply`. This methodology is much better as it reports whenever the new CMake function fails to apply a certain patch. Note: This solution is based on what TF-M implemented in `components/security/trusted_firmware-m/library/cmake/ remote_library.cmake` Signed-off-by: Ahmed Ismail <[email protected]>
urutva
approved these changes
Feb 5, 2024
aggarg
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new way of applying patches is added to fix Corstone300 platform hardfault exception happening as the TF-M patch
(components/security/trusted_firmware-m/integration/patches /0001-corstone300-Modify-ISRAM0-to-be-non-secure-partition.patch) for this platform is sometimes not applied.
Patches are now applied using
git stashandgit apply. This methodology is much better asit reports whenever the new CMake function fails
to apply a certain patch.
Note:
This solution is based on what TF-M implemented in
components/security/trusted_firmware-m/library/cmake/ remote_library.cmakeDescription
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.